On Mon, Mar 10, 2025 at 01:29:04PM -0500, Eric Sandeen wrote: > There are several #ifdef linux guards in the code, which caused > a few sparse warnings, because while gcc defines both linux > and __linux__, sparse defines only __linux__. So, switch our > guards to check for __linux__ which hch says "is the preferred > version these days." > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Sorry for nitpicking, bu "he says" is usually not a good way to write commit logs. Just state that __linux__ is also pre-defined by sparse. The changes themselves look good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
