On Wed, Feb 26, 2025 at 10:37:20AM +0000, Filipe Manana wrote: > On Tue, Feb 25, 2025 at 10:19 PM Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > diff --git a/tests/btrfs/029 b/tests/btrfs/029 > > index c37ad63fb..1f8201af3 100755 > > --- a/tests/btrfs/029 > > +++ b/tests/btrfs/029 > > @@ -74,7 +74,7 @@ cp --reflink=always $orig_file $copy_file >> $seqres.full 2>&1 || echo "cp refli > > md5sum $orig_file | _filter_testdir_and_scratch > > md5sum $copy_file | _filter_testdir_and_scratch > > > > -$UMOUNT_PROG $reflink_test_dir > > +_unmount $reflink_test_dir > > This isn't equivalent to directly calling UMOUNT_PROG since the > _unmount helper always redirects stdout and stderr to $seqres.full. Please update your tree to the latest for-next. _unmount does, indeed, return stdout/stderr to the caller, and so as the commit message says, it is a drop-in replacement for UMOUNT_PROG. I wouldn't have sent the patch in this form if that hadn't been fixed. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
