On Mon, 24 Feb 2025 at 12:10, Daniel Vacek <neelx@xxxxxxxx> wrote:
>
> When SELinux is enabled this test fails unable to receive a file with
> security label attribute:
>
> --- tests/btrfs/314.out
> +++ results//btrfs/314.out.bad
> @@ -17,5 +17,6 @@
> At subvol TEST_DIR/314/tempfsid_mnt/snap1
> Receive SCRATCH_MNT
> At subvol snap1
> +ERROR: lsetxattr foo security.selinux=unconfined_u:object_r:unlabeled_t:s0 failed: Operation not supported
> Send: 42d69d1a6d333a7ebdf64792a555e392 TEST_DIR/314/tempfsid_mnt/foo
> -Recv: 42d69d1a6d333a7ebdf64792a555e392 SCRATCH_MNT/snap1/foo
> +Recv: d41d8cd98f00b204e9800998ecf8427e SCRATCH_MNT/snap1/foo
> ...
>
> Setting the security label file attribute fails due to the default mount
> option implied by fstests:
>
> MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/sdb /mnt/scratch
>
> See commit 3839d299 ("xfstests: mount xfs with a context when selinux is on")
>
> fstests by default mount test and scratch devices with forced SELinux
> context to get rid of the additional file attributes when SELinux is
> enabled. When a test mounts additional devices from the pool, it may need
> to honor this option to keep on par. Otherwise failures may be expected.
>
> Moreover this test is perfectly fine labeling the files so let's just
> disable the forced context for this one.
And of course I forgot to remove this sentence. Please, remove it if
you decide to merge this fix.
> Signed-off-by: Daniel Vacek <neelx@xxxxxxxx>
> ---
> tests/btrfs/314 | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/314 b/tests/btrfs/314
> index 76dccc41..29111ece 100755
> --- a/tests/btrfs/314
> +++ b/tests/btrfs/314
> @@ -38,7 +38,7 @@ send_receive_tempfsid()
> # Use first 2 devices from the SCRATCH_DEV_POOL
> mkfs_clone ${SCRATCH_DEV} ${SCRATCH_DEV_NAME[1]}
> _scratch_mount
> - _mount ${SCRATCH_DEV_NAME[1]} ${tempfsid_mnt}
> + _mount $(_common_dev_mount_options) ${SCRATCH_DEV_NAME[1]} ${tempfsid_mnt}
>
> $XFS_IO_PROG -fc 'pwrite -S 0x61 0 9000' ${src}/foo | _filter_xfs_io
> _btrfs subvolume snapshot -r ${src} ${src}/snap1
> --
> 2.48.1
>
