On Thu, Feb 20, 2025 at 09:37:51PM +0100, David Sterba wrote:
> On Fri, Feb 21, 2025 at 04:22:38AM +0800, Zorro Lang wrote:
> > On Wed, Feb 19, 2025 at 11:17:43PM +0100, David Sterba wrote:
> > > The linux kernel removed Reiserfs support in 6.13 so remove it from the
> > > tests as well.
> > >
> > > Signed-off-by: David Sterba <dsterba@xxxxxxxx>
> > > ---
> > >
> > > Arguably reiser4 support could be removed as well as there's no recent
> > > upstream activity.
> >
> > Thanks for doing this :) But even with this patch, I still can find more
> > "reiser*" related things as below. How about removing them all?
> >
> > zorro@zlang-laptop:~/git/upstream/xfs/xfstests-dev$ grep -rsni reiser .
> > ./common/config:330:export MKFS_REISER4_PROG=$(type -P mkfs.reiser4)
> > ./common/config:390: reiser4)
> > ./common/config:391: # acls & xattrs aren't supported by reiser4
> > ./common/config:392: echo $REISER4_MOUNT_OPTIONS
> > ./common/config:443: reiser4)
> > ./common/config:444: export MKFS_OPTIONS=$REISER4_MKFS_OPTIONS
> > ./common/config:472: reiser*)
> > ./common/config:540: reiser4)
> > ./common/config:541: [ "$MKFS_REISER4_PROG" = "" ] && _fatal "mkfs.reiser4 not found"
> > ./common/rc:1227: ext2|ext3|ext4|reiser4|ocfs2)
> > ./common/rc:1331: reiser4)
> > ./common/rc:1333: $MKFS_REISER4_PROG $MKFS_OPTIONS -y -b $blocksize "$@" $SCRATCH_DEV \
>
> This is reiser4, the reasoning would be different as it's an out-of-tree
> module but still somehow developed so there's a chance somebody is using
> it.
Sorry I saw you said "Arguably reiser4 support could be removed as well
as there's no recent upstream activity.", then removed reiser4 from
generic/740 [1], so I thought you want to remove it too :)
OK, I'm good to keep reiser4 for a while.
Thanks,
Zorro
[1]
diff --git a/tests/generic/740 b/tests/generic/740
index 10817521cc9342..c167dbef2ff68a 100755
--- a/tests/generic/740
+++ b/tests/generic/740
@@ -63,10 +63,6 @@ do
# "quick" format that doesn't zero the entire device
postargs="--quick"
;;
- reiserfs|reiser4)
- preop="echo y |"
- preargs="-f"
- ;;
>
