On Fri, Feb 14, 2025 at 03:50:31PM -0500, Theodore Ts'o wrote:
> On Fri, Feb 14, 2025 at 09:56:44AM -0800, Darrick J. Wong wrote:
> > > The tools/ directory never be installed into /var/lib/xfstests. If someone runs
> > > xfstests after `make install`, all tests will be failed due to:
> > >
> > > Failed to find executable ./tools/run_setsid: No such file or directory
> >
> > Urrrk, yeah, I didn't realize that tools/ doesn't have a Makefile,
> > therefore nothing from there get installed. Three options:
> >
> > 1) Add a tools/Makefile and an install target
> > 2) Update the top level Makefile's install target to install the two
> > scripts
> > 3) Move tools/run_* to the top level and (2)
>
> Looking at tools, it seems like there are a couple of different
> categories of scripts in the directory. Some are useful to people who
> are developing fstests (mkgroupfile, nextid, mvtest); some are useful
> when debugging a test failure (dm-logwrite-replay); some are useful
> only to xfs developers (ag-wipe, db-walk).
>
> And to this we are adding utility programs that would be used during a
> test execution.
>
> I wonder if we should split out these scripts into different
> directories?
Hi Ted,
Thanks for taking care of this issue. Yes, I talked with Darrick about
that. I provided 3 methods:
1) Change xfstests/Makefile only.
2) Add Makefile to tools/ to install the scripts we need.
3) Create another directory (e.g. scripts) to save the scripts for testing,
and give it Makefile.
After talking, we chose the 2nd one, something likes:
TOPDIR = ..
include $(TOPDIR)/include/builddefs
TOOLS_DIR = tools
TARGETS = run_setsid run_privatens
include $(BUILDRULES)
default: $(TARGETS)
install: default
$(INSTALL) -m 755 -d $(PKG_LIB_DIR)/$(TOOLS_DIR)
$(INSTALL) -m 755 $(TARGETS) $(PKG_LIB_DIR)/$(TOOLS_DIR)
install-dev install-lib:
The 3rd one is good to me too, as tools/ directory isn't used for
test running from beginning. I think we can let the patches of
Darrick be merged at first. Then I can send another patch to talk
about the "separated directory" way :)
Thanks,
Zorro
>
> - Ted
>
>
