On Tue, 11 Feb 2025 16:22:57 +1030, Qu Wenruo wrote:
...
> diff --git a/src/dio-writeback-race.c b/src/dio-writeback-race.c
> new file mode 100644
> index 000000000000..f0a2f6de531b
> --- /dev/null
> +++ b/src/dio-writeback-race.c
> @@ -0,0 +1,148 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * dio_writeback_race -- test direct IO writes with the contents of
> + * the buffer changed during writeback.
> + *
> + * Copyright (C) 2025 SUSE Linux Products GmbH.
> + */
> +
> +/*
> + * dio_writeback_race
> + *
> + * Compile:
> + *
> + * gcc -Wall -pthread -o dio_writeback_race dio_writeback_race.c
nit: hyphens instead of underscores: dio-writeback-race.c
...
> + fd = open(argv[optind], O_DIRECT | O_WRONLY | O_CREAT);
> + if (fd < 0) {
> + fprintf(stderr, "failed to open file '%s': %m\n", argv[2]);
argv[optind] instead of argv[2] in the error msg. With that fixed:
Reviewed-by: David Disseldorp <ddiss@xxxxxxx>
