Re: [PATCH] generic: suggest fs specific fix only if the tested filesystem matches

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Feb 07, 2025 at 07:42:29AM +1030, Qu Wenruo wrote:
> 
> 
> 在 2025/2/7 00:41, Christoph Hellwig 写道:
> > On Thu, Feb 06, 2025 at 01:05:06PM +0000, fdmanana@xxxxxxxxxx wrote:
> > > +if [ "$FSTYP" = "xfs" ]; then
> > > +	_fixed_by_kernel_commit 68415b349f3f \
> > > +		"xfs: Fix the owner setting issue for rmap query in xfs fsmap"
> > > +	_fixed_by_kernel_commit ca6448aed4f1 \
> > > +		"xfs: Fix missing interval for missing_owner in xfs fsmap"
> > > +fi
> > 
> > How about you add a new helper instead of the boilerplate, something
> > like
> > 
> > _fixed_by_fs_kernel_commit xfs 68415b349f3f \
> > 	"xfs: Fix the owner setting issue for rmap query in xfs fsmap"
> > 
> > ?
> > 
> But what if the fix is generic? E.g. in mm/VFS layer?
> 
> Should we choose some placeholder name like "generic" as a fs type instead?

Keep using _fixed_by_kernel_commit then.

--D

> Thanks,
> Qu
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux