Re: [PATCH] generic/631: suggest xfs fix only if the tested filesystem is xfs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Feb 6, 2025 at 12:26 PM <fdmanana@xxxxxxxxxx> wrote:
>
> From: Filipe Manana <fdmanana@xxxxxxxx>
>
> It's odd when a test fails on a filesystem that is not xfs and it suggests
> that a xfs specific fix may be missing, which obviously is irrelevant.
> So suggest the fix only if we are running on xfs.
>
> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>

Scratch that, there are more generic tests doing this, so replacing
this patch with another one to fix all of them:

https://lore.kernel.org/linux-btrfs/8c64ba21953b44b682c72b448bebe273dba64013.1738847088.git.fdmanana@xxxxxxxx/

Thanks.

> ---
>  tests/generic/631 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/631 b/tests/generic/631
> index 8e2cf9c6..c38ab771 100755
> --- a/tests/generic/631
> +++ b/tests/generic/631
> @@ -41,7 +41,7 @@ _require_attrs trusted
>  _exclude_fs overlay
>  _require_extra_fs overlay
>
> -_fixed_by_kernel_commit 6da1b4b1ab36 \
> +[ "$FSTYP" = "xfs" ] && _fixed_by_kernel_commit 6da1b4b1ab36 \
>         "xfs: fix an ABBA deadlock in xfs_rename"
>
>  _scratch_mkfs >> $seqres.full
> --
> 2.45.2
>
>





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux