Re: [PATCH v2 0/5] fstests: btrfs: add test case to validate sysfs input arguments

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]





On 6/2/25 05:21, Dave Chinner wrote:
On Wed, Feb 05, 2025 at 07:06:35PM +0800, Anand Jain wrote:
v2:
Mainly adds a generic function to check if a sysfs attribute reports
invalid input.

v1:
https://lwn.net/ml/all/cover.1738161075.git.anand.jain@xxxxxxxxxx/

Anand Jain (5):
   fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout
   fstests: filter: helper for sysfs error filtering
   fstests: common/rc: add sysfs argument verification helpers
   fstests: btrfs: testcase for sysfs policy syntax verification
   fstests: btrfs: testcase for sysfs chunk_size attribute validation

All looks ok, except for my comment about creating common/sysfs for
all the sysfs stuff. The individual tests look much simpler and
nicer, too.


Yeah, the sysfs functions need a new file. I'll send the reorg cleanups.

Thx, Anand

-Dave.





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux