On Wed, Feb 05, 2025 at 11:16:16AM +1100, Dave Chinner wrote: > On Tue, Feb 04, 2025 at 01:25:26PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > The next patch in this series fixes various issues with the recently > > added fstests process isolation scheme by running each new process in a > > separate process group session. Unfortunately, the processes in the > > session are created with SIGINT ignored by default because they are not > > attached to the controlling terminal. Therefore, switch the kill signal > > to SIGPIPE because that is usually fatal and not masked by default. > > > > Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> > > --- > > common/fuzzy | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > Change looks fine, but _pkill is not yet defined. It is introduced > in the next patch "common/rc: hoist pkill to a helper function" > so this needs to be reordered. Fixed. > With that done, however: > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Thanks for spotting that, and for the review! --D > -- > Dave Chinner > david@xxxxxxxxxxxxx >
