On Wed, Feb 05, 2025 at 04:44:22PM +0100, Christoph Hellwig wrote: > On Tue, Feb 04, 2025 at 09:12:58AM -0800, Darrick J. Wong wrote: > > Hmmmm... I have a patch with a similar aim in my dev tree that > > determines the lba size from whatever mkfs decides is the sector size: > > > > # Figure out what sector size mkfs will use to format, which might be dependent > > # upon the directio write geometry of the test filesystem. > > loop_file=$TEST_DIR/$seq.loop > > rm -f "$loop_file" > > truncate -s 16M "$loop_file" > > $MKFS_XFS_PROG -f -N "$loop_file" | _filter_mkfs 2>$tmp.mkfs >/dev/null > > . $tmp.mkfs > > seqfull=$0 > > _link_out_file "lba${sectsz}" > > > > What do you think of that approach? > > That sound sensible. Where is that patch, it doesn't seem to be > in the realtime-reflink branch that I'm usually working against. It's one of the few zoned changes I have in the fstests branch: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=zoned_2025-02-04 --D