On Wed, Jan 29, 2025 at 06:24:43AM +0100, Christoph Hellwig wrote: > On Tue, Jan 28, 2025 at 11:31:22AM -0800, Darrick J. Wong wrote: > > Should this get turned into a common helper? > > > I guess the downside is that pvcreate on my system (Debian 12) will trip > > over any existing disk label and ask if you want to wipe it. If you say > > no then it returns nonzero, and if you say yes then it goes into an > > infinite loop. > > > > You can of course $WIPEFS_PROG -a $bdev but ugghh. > > Honestly, for now I just want to avoid the tests failing due to lvm > stupidity. If someone has the time to do something more elaborate > (I don't right now), the proper thing is to stop using lvm and replace > it with something less stupid. That might be direct use of dm, > or simulating failures with null_blk or scsi_debug. Eh, I'm not that into a weird wipefs and pvcreate --test. If someone feels so motivated to test that on a bunch of distros they can do that refactoring. I already have too many patches stuck in djwong-dev. Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx> --D
