On Thu, Jan 16, 2025 at 03:25:42PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > In _xfs_verify_metadump_v2(), we want to set up some loop devices, > record the names of those loop devices, and then leave the variables in > the global namespace so that _xfs_cleanup_verify_metadump can dispose of > them. > > Elsewhere in fstests the convention for global variables is to put them > in all caps to make it obvious that they're global and not local > variables, so do that here too. I did this because they are local to the file and nothing external accesses them. So I converted them to be the same as all other file-scope loop device names which are all lower case. But it really doesn't matter at all, so if that's what you want then: Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
