On Fri, Jan 17, 2025 at 09:27:36AM -0800, Darrick J. Wong wrote: > On Fri, Jan 17, 2025 at 12:37:09PM +0800, Zorro Lang wrote: > > GCC-15 does a big change, it changes the default language version for > > C compilation from -std=gnu17 to -std=gnu23. That cause lots of "old > > style" C codes hit build errors. On the other word, current xfstests > > can't be used with GCC-15. So -std=gnu17 can help that. > > > > Signed-off-by: Zorro Lang <zlang@xxxxxxxxxx> > > --- > > > > Hi, > > > > I send this patch just for talking about this issue. The upcoming gcc-15 > > does lots of changes, a big change is using C23 by default: > > > > https://gcc.gnu.org/gcc-15/porting_to.html > > > > xfstests has many old style C codes, they hard to be built with gcc-15. > > So we have to either add -std=$old_version (likes this patch), or port > > the code to C23. > > > > This patch is just a workaround (and a reminder for someone might hit > > this issue with gcc-15 too). If you have any good suggestions or experience > > (for this kind of issue) to share, feel free to reply. > > -std=gnu11 to match the kernel and xfsprogs? So you prefer using a settled "-std=xxx" to changing codes to match "gnu23"? > > --D > > > Thanks, > > Zorro > > > > include/builddefs.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/builddefs.in b/include/builddefs.in > > index 5b5864278..ef124bb87 100644 > > --- a/include/builddefs.in > > +++ b/include/builddefs.in > > @@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@ > > NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@ > > HAVE_FICLONE = @have_ficlone@ > > > > -GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall > > +GCCFLAGS = -funsigned-char -fno-strict-aliasing -std=gnu17 -Wall > > SANITIZER_CFLAGS += @autovar_init_cflags@ > > > > ifeq ($(PKG_PLATFORM),linux) > > -- > > 2.47.1 > > > > >
