Re: [PATCH] include/builddefs.in: ignore unused-result warning

Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> · Wed, 15 Jan 2025 17:15:32 +0800

ping~

在 2025/1/6 17:59, Shiyang Ruan 写道:
When build xfstests, a lot of "unused result" warning are reported:

     [CC] write_log.lo
write_log.c: In function 'wlog_record_write':
write_log.c:205:13: warning: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Wunused-result]
   205 |             write(wfile->w_afd, wbuf, reclen);
       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
write_log.c:209:13: warning: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Wunused-result]
   209 |             write(wfile->w_rfd, wbuf, reclen);
       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     [CC] random.lo

Mostly are calused by not using the return value of read()/write()/...
Ignore this warning by adding `-Wno-unused-result` to CCFLAGS.  This
won't cause other problem but make the log clean.

Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
---
  include/builddefs.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/builddefs.in b/include/builddefs.in
index 7274cde8d..edf87ff00 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@
  NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@
  HAVE_FICLONE = @have_ficlone@
  
-GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
+GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall -Wno-unused-result
  
  ifeq ($(PKG_PLATFORM),linux)
  PCFLAGS = -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 $(GCCFLAGS)







