On 1/13/25 8:48 PM, Shin'ichiro Kawasaki wrote:
> Commit d6b9d8eff076 ("fsx: add support for RWF_DONTCACHE") introduced
> preadv2() calls in ltp/fsx.c. However, sys/uio.h is not included to the
> source file, which causes compile errors with the gcc option
> -Werror-implicit-function-declaration:
>
> fsx.c: In function 'test_dontcache_io':
> fsx.c:1956:15: error: implicit declaration of function 'preadv2'; did you mean 'pread64'? [-Wimplicit-function-declaration]
> 1956 | ret = preadv2(fd, &iov, 1, 0, RWF_DONTCACHE);
> | ^~~~~~~
> | pread64
> fsx.c: In function 'fsx_rw':
> fsx.c:2836:31: error: implicit declaration of function 'pwritev2'; did you mean 'pwrite64'? [-Wimplicit-function-declaration]
> 2836 | ret = pwritev2(fd, &iov, 1, offset, flags);
> | ^~~~~~~~
> | pwrite64
>
> To fix it, add the include directive.
Looks good, thanks for catching that.
Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>
--
Jens Axboe
