On 6/1/25 02:25, Anand Jain wrote: >>> + >>> +_scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed" >>> +sector_size=$(_scratch_btrfs_sectorsize) >>> + >>> +if [[ $sector_size -ne 4096 && $sector_size -ne 65536 ]]; then >>> + _notrun "sector size $sector_size not supported by this test" >>> +fi >>> + > > _require_btrfs_support_sectorsize <xx> > All the rest looks good, but this isn't right. _require_btrfs_support_sectorsize tests for kernel support, I'm just accounting for the fact I've only written the test for 4k and 64k sector sizes. I'll move this bit to the if statement that follows, to make it clearer what I'm doing. Mark
