Re: [PATCH] common: call _require_scratch_dedupe from _require_scratch_duperemove

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Dec 10, 2024 at 07:53:15AM +0100, Christoph Hellwig wrote:
> _require_scratch_duperemove doesn't check if the scratch file system
> actually supports dedup, so add the proper call for that.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> 
> Btw, I wonder if we should simply stop using dupremove in favor of the
> xfs_io dedup command which seems lot less cumbersome?  For now this is
> a quick fix, though.
> 
>  common/reflink | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/common/reflink b/common/reflink
> index 22adc4449bc6..9177c45e70bb 100644
> --- a/common/reflink
> +++ b/common/reflink
> @@ -83,6 +83,8 @@ _require_scratch_duperemove()
>  
>  	_scratch_mkfs > /dev/null
>  	_scratch_mount
> +	_require_scratch_dedupe

Thanks, it makes sense to me.

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

I brought in "duperemove" just for giving dedupe feature a random stress test.
I never thought the duperemove project can't be stable long time. If anyone
knows any other tools can replace duperemove, I can change duperemove to
others.

Thanks,
Zorro

> +
>  	dd if=/dev/zero of="$SCRATCH_MNT/file1" bs=128k count=1 >& /dev/null
>  	dd if=/dev/zero of="$SCRATCH_MNT/file2" bs=128k count=1 >& /dev/null
>  	if ! "$DUPEREMOVE_PROG" -d "$SCRATCH_MNT/file1" \
> -- 
> 2.45.2
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux