On Sun, Dec 08, 2024 at 01:07:18PM -0500, cel@xxxxxxxxxx wrote: > From: Chuck Lever <chuck.lever@xxxxxxxxxx> > > On NFS mounts, at least, generic/559, 560, and 561 run for a very > long time, and usually fail. > > The above tests already gate on whether duperemove is installed on > the test system, but when fstests is installed as part of an > automated workflow designed to handle many filesystem types, > duperemove is installed by default. > > duperemove(8) states: > > Deduplication is currently only supported by the btrfs and xfs > filesystem. If so, I'm good to limit this test on btrfs and xfs. It might be better to add this comment to "_supported_fs btrfs xfs". Anyway, Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> (This's a fstests patch, send to fstests@xxxxxxxxxxxxxxx.) Thanks, Zorro > > Ensure that the generic dedupe tests are run on only filesystems > where duperemove is known to work. > > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > --- > tests/generic/559 | 1 + > tests/generic/560 | 1 + > tests/generic/561 | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/tests/generic/559 b/tests/generic/559 > index 28cf2e1a32c2..cf80be92142d 100755 > --- a/tests/generic/559 > +++ b/tests/generic/559 > @@ -13,6 +13,7 @@ _begin_fstest auto stress dedupe > . ./common/filter > . ./common/reflink > > +_supported_fs btrfs xfs > _require_scratch_duperemove > > fssize=$((2 * 1024 * 1024 * 1024)) > diff --git a/tests/generic/560 b/tests/generic/560 > index 067d3ec0049e..a94b512efda1 100755 > --- a/tests/generic/560 > +++ b/tests/generic/560 > @@ -15,6 +15,7 @@ _begin_fstest auto stress dedupe > . ./common/filter > . ./common/reflink > > +_supported_fs btrfs xfs > _require_scratch_duperemove > > _scratch_mkfs > $seqres.full 2>&1 > diff --git a/tests/generic/561 b/tests/generic/561 > index afe727ac56cb..da5f111c5b23 100755 > --- a/tests/generic/561 > +++ b/tests/generic/561 > @@ -28,6 +28,7 @@ _cleanup() > . ./common/filter > . ./common/reflink > > +_supported_fs btrfs xfs > _require_scratch_duperemove > > _scratch_mkfs > $seqres.full 2>&1 > -- > 2.47.0 > >
