On 12/5/2024 11:21 PM, Luis Chamberlain wrote:
On Thu, Dec 05, 2024 at 08:41:22AM +0100, Daniel Gomez wrote:
On 12/5/2024 1:26 AM, Luis Chamberlain wrote:
We had added support for open coding a patient module remover long
ago on fstests through commit d405c21d40aa1 ("common/module: add patient
module rmmod support") to fix many flaky tests. This assumed we'd end up
with modprobe -p -t <msec-timeout> but in the end kmod upstream just
I can't find modprobe -p and/or -t arguments in the manual. What do they
mean?
I had proposed -p to mean patient module remover with a default timeout
set, -t to override. In the end this went upstream instead over a lot of
dialog with just -w <timeout>.
but i can't find the module remover support in kmod.
Nit. I find useful using the long argument instead of the short one (e.g.
--wait instead of -w). as it's usually self-descriptive. But I guess we
don't have that long option for -p and -t?
It was one or the other that went upstream, we implemented this on
fstests upstream as an open coded solution while we wanted for this
meachanism to be agreed upon and merged. I just forgot to come back to
this after -w was merged and decided upon.
Thanks for clarifying.
Luis
