Re: [PATCH v4 2/3] common/rc: Add a new _require_scratch_extsize helper function

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]




On 11/27/24 06:24, Darrick J. Wong wrote:
On Tue, Nov 26, 2024 at 11:24:07AM +0530, Nirjhar Roy wrote:
_require_scratch_extsize helper function will be used in the
the next patch to make the test run only on filesystems with
extsize support.

Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
Signed-off-by: Nirjhar Roy <nirjhar@xxxxxxxxxxxxx>
Looks good to me now,
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

Thank you.

--NR


---
  common/rc | 17 +++++++++++++++++
  1 file changed, 17 insertions(+)

diff --git a/common/rc b/common/rc
index f94bee5e..e6c6047d 100644
--- a/common/rc
+++ b/common/rc
@@ -48,6 +48,23 @@ _test_fsxattr_xflag()
  	grep -q "fsxattr.xflags.*\[.*$2.*\]" <($XFS_IO_PROG -c "stat -v" "$1")
  }
+# This test requires extsize support on the filesystem
+_require_scratch_extsize()
+{
+	_require_scratch
+	_require_xfs_io_command "extsize"
+	_scratch_mkfs > /dev/null
+	_scratch_mount
+	local filename=$SCRATCH_MNT/$RANDOM
+	local blksz=$(_get_block_size $SCRATCH_MNT)
+	local extsz=$(( blksz*2 ))
+	local res=$($XFS_IO_PROG -c "open -f $filename" -c "extsize $extsz" \
+		-c "extsize")
+	_scratch_unmount
+	grep -q "\[$extsz\] $filename" <(echo $res) || \
+		_notrun "this test requires extsize support on the filesystem"
+}
+
  # Write a byte into a range of a file
  _pwrite_byte() {
  	local pattern="$1"
--
2.43.5


--
---
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux