Re: [PATCH] btrfs: add test for encoded reads

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 21/11/24 00:31, Johannes Thumshirn wrote:
On 20.11.24 17:14, Mark Harmstone wrote:
On 14/11/24 05:06, Zorro Lang wrote:
...

It looks like IORING_OP_URING_CMD was added to liburing with version
2.2, which came out in June 2022. I don't know whether that's old enough
that we can just declare it as our minimum version, whether we should be
probing for the liburing version, whether we should be working round
this somehow, or what.

Zorro, what do you think?

2022 was just 2 years ago, some downstream distributions might use old version.
I think that might be too early to leave a "2 years ago" system out of the using of
latest xfstests :)

Thanks,
Zorro

Okay, no worries. I can change it so that it uses the raw syscalls
rather than the liburing helpers. It'll be a lot uglier, but at least
it'll work.

Johannes, what distro and version are you on? I'll make sure it works on
that.

I'm on openSUSE 15.6 atm.



Sorry for the delayed comment. Systems without the latest headers files
(missing `BTRFS_IOC_ENCODED_READ`) will fail to compile, e.g., OL9 with UEK7.

   27 |         struct btrfs_ioctl_encoded_io_args enc;
btrfs_encoded_read.c:27:44: error: storage size of 'enc' isn't known


btrfs_encoded_read.c:43:25: error: 'BTRFS_IOC_ENCODED_READ' undeclared (first use in this function); did you mean 'BTRFS_IOC_DEVICES_READY'?
   43 |         ret = ioctl(fd, BTRFS_IOC_ENCODED_READ, &enc);


fstests ./configure may need to manage feature enable?.


Thanks, Anand


Thanks,
	Johannes





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux