Re: [PATCH] xfs/229: call on the test directory

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Nov 19, 2024 at 03:55:07PM +0100, Christoph Hellwig wrote:
> xfs/229 operates on a directory that is forced to the data volume, but
> it calls _require_fs_space on $TEST_DIR which might point to the RT
> device when -d rtinherit is set.
> 
> Call _require_fs_space on $TDIR after it is create to check for the
> space actually used by the test.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Whoops, I missed that when I put in _xfs_force_bdev :(

Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  tests/xfs/229 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/229 b/tests/xfs/229
> index 9dae0f6496e9..3ac1f9401a1a 100755
> --- a/tests/xfs/229
> +++ b/tests/xfs/229
> @@ -24,7 +24,6 @@ _cleanup()
>  # Import common functions.
>  
>  _require_test
> -_require_fs_space $TEST_DIR 3200000
>  
>  TDIR="${TEST_DIR}/t_holes"
>  NFILES="10"
> @@ -39,6 +38,9 @@ mkdir ${TDIR}
>  # that will affect other tests.
>  _xfs_force_bdev data $TDIR
>  
> +# check for free space on the data volume even if rthinherit is set
> +_require_fs_space $TDIR 3200000
> +
>  # Set the test directory extsize
>  $XFS_IO_PROG -c "extsize ${EXTSIZE}" ${TDIR}
>  
> -- 
> 2.45.2
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux