Re: Re: [PATCH 2/2] generic: increase file size to match CoW delayed allocation for XFS 64k bs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



> > +++ b/tests/generic/305
> > @@ -32,7 +32,7 @@ quotaon $SCRATCH_MNT 2> /dev/null
> >  testdir=$SCRATCH_MNT/test-$seq
> >  mkdir $testdir
> >  
> > -sz=1048576
> > +sz=4194304
> 
> Hm, so you're increasing the filesize so that it exceeds 32*64k?
> Hence 4M for some nice round numbers?
> 

Actually we do a CoW write for sz/2 in the test. So I wanted sz/2 to
match 2M (32 * 64k). I hope that makes sense.

> If so then I think I'm fine with that.  Let's see what testing thinks.
> :)

:) All the other solutions might require fs specific changes, so I went
with this approach. Let's hope this works.

> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
Thanks!

--
Pankaj




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux