Re: [PATCH] generic/694: sync before sampling i_blocks

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Oct 09, 2024 at 07:48:17AM -0700, Darrick J. Wong wrote:
> > +# make sure indirect block reservations and other temporary block reservations
> > +# are release before sampling i_blocks
> 
> Nit: '...are released before...'
> 
> > +sync
> 
> Should this be more targeted since we only care about junk_file's
> i_blocks, not flushing everything in the system. e.g.
> 
> sync $junk_file

I didn't even know sync took an optional file argument.  But yes,
that should be fine.




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux