Re: [xfstests PATCH] generic/362: skip test on NFS mount

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, Sep 03, 2024 at 10:18:09AM +0800, Chen Hanxiao wrote:
> xfstests complains:
> 
> # ./check -d generic/362
> FSTYP         -- nfs
> PLATFORM      -- Linux/x86_64 r95b-1 5.14.0-496.el9.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Aug 12 18:50:44 EDT 2024
> MKFS_OPTIONS  -- 192.168.122.42:/nfsscratch
> MOUNT_OPTIONS -- -o vers=4.2 192.168.122.42:/nfsscratch /mnt/scratch
> 
> generic/362       QA output created by 362
> Failed to open/create file: Invalid argument
> Silence is golden
> - output mismatch (see /var/lib/xfstests/results//generic/362.out.bad)
>     --- tests/generic/362.out   2024-09-02 14:27:09.162636093 -0400
>     +++ /var/lib/xfstests/results//generic/362.out.bad  2024-09-02 14:33:36.167636093 -0400
>     @@ -1,2 +1,3 @@
>      QA output created by 362
>     +Failed to open/create file: Invalid argument
>      Silence is golden
>     ...
>     (Run 'diff -u /var/lib/xfstests/tests/generic/362.out /var/lib/xfstests/results//generic/362.out.bad'  to see the entire diff)
> Ran: generic/362
> Failures: generic/362
> Failed 1 of 1 tests
> 
> NFS commit 9597c13b forbade open with O_APPEND|O_DIRECT

OK, thanks for pointing this out.

> 
> strace show that dio-append-buf-fault use (O_APPEND|O_DIRECT):
> 
>  mount -o vers=4.2 192.168.122.42:/nfstest /mnt/scratch/
>  strace ./src/dio-append-buf-fault /mnt/scratch/111
> ..
>   openat(AT_FDCWD, "/mnt/scratch/111", O_WRONLY|O_CREAT|O_TRUNC|O_APPEND|O_DIRECT, 0666) = 3
> 
> So skip generic/362 on NFS
> 
> Signed-off-by: Chen Hanxiao <chenhx.fnst@xxxxxxxxxxx>
> ---
>  tests/generic/362 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/generic/362 b/tests/generic/362
> index f5b4ed06..d7bb0125 100755
> --- a/tests/generic/362
> +++ b/tests/generic/362
> @@ -18,6 +18,8 @@ _require_test_program dio-append-buf-fault
>  	_fixed_by_kernel_commit 939b656bc8ab \
>  	"btrfs: fix corruption after buffer fault in during direct IO append write"
>  
> +test $FSTYP == "nfs"  && _notrun "NFS forbade open with O_APPEND|O_DIRECT"

To skip nfs, you can add this line:

  # NFS forbade open with O_APPEND|O_DIRECT
  _supported_fs ^nfs

before _require_test.

I think that's simple enough, I can help to do this change when I merge it, if
there's not more review points from nfs list.

Thanks,
Zorro

> +
>  # On error the test program writes messages to stderr, causing a golden output
>  # mismatch and making the test fail.
>  $here/src/dio-append-buf-fault $TEST_DIR/dio-append-buf-fault
> -- 
> 2.43.5
> 
> 





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux