Re: [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

Subject: Re: [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 13 Aug 2024 16:56:25 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Zorro Lang <zlang@xxxxxxxxxx>, fstests@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <20240813144331.GF6047@frogsfrogsfrogs>
References: <20240813073527.81072-1-hch@lst.de> <20240813073527.81072-5-hch@lst.de> <20240813144331.GF6047@frogsfrogsfrogs>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Aug 13, 2024 at 07:43:31AM -0700, Darrick J. Wong wrote:
> > +min_dio_sz=$($here/src/feature -s)
> 
> Or maybe _get_page_size() ?

Sure.  Or maybe actually query the I/O size, but I need feedback
from the authors that they actually intended that..

References:
- improve minalign handling
  - From: Christoph Hellwig
- [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument
  - From: Christoph Hellwig
- Re: [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 2/5] add a new min_dio_alignment helper
Next by Date: [PATCH fstests] generic/755: test that inode's ctime is updated on unlink
Previous by thread: Re: [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument
Next by thread: [PATCH 5/5] replace _min_dio_alignment with calls to src/min_dio_alignment
Index(es):
- Date
- Thread

[Index of Archives] [Linux Filesystems Development] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]

Powered by Linux