On Fri, Jul 12, 2024 at 05:49:24PM GMT, Zorro Lang wrote:
> On Sun, Jun 30, 2024 at 11:52:43PM +0200, Daniel Gomez via B4 Relay wrote:
> > From: Daniel Gomez <da.gomez@xxxxxxxxxxx>
> >
> > MOUNT_OPTIONS for scratch devices do not have specific fs mount options
> > values (such as TMPFS_MOUNT_OPTIONS) from the config section. So, allow
> > the scratch mount options to inherit section config values by reading
> > them from _common_mount_opts().
> >
> > Move $* to the end so scratch device can be umount/mount. Otherwise, we
> > end up with multiple mounts in the same scratch directory.
> >
> > Signed-off-by: Daniel Gomez <da.gomez@xxxxxxxxxxx>
> > ---
> > common/rc | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/common/rc b/common/rc
> > index 51827119c..627dbaaaa 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -231,8 +231,8 @@ _scratch_mount_options()
> > {
> > _scratch_options mount
> >
> > - echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
> > - $SCRATCH_DEV $SCRATCH_MNT
> > + echo `_common_mount_opts` $SCRATCH_OPTIONS \
> > + $SCRATCH_DEV $SCRATCH_MNT $*
>
> Oh, you want to get the "specific fs mount options". But sorry this
> change brings in many regression failures, e.g. generic/219, generic/691,
> generc/381, generic/382 ... fail (on ext4 and so on).
Kindly ping.
Following my previous question, I'm trying to elaborate more:
Could you please clarify why these specific filesystem mount options should not
be applied to scratch devices? If this is a regression, could it be due to
the application of $EXT_MOUNT_OPTIONS? And maybe a configuration issue?
The purpose of this change was to provide the common mount options for scratch
devices, so that I can inherit the required options for tmpfs (e.g., '-o size=1G
$TMPFS_MOUNT_OPTIONS').
Here is my current configuration, but it seems I'm missing something, as I'm
expecting the scratch (and test) mounts to inherit $TMPFS_MOUNT_OPTIONS when
running ./check -s <config>.
mkdir -p /media/scratch
mkdir -p /media/test
export FSTYP=tmpfs
export SCRATCH_DEV=/media/scratch
export SCRATCH_MNT=/media/scratch
export TEST_DEV=/media/test
export TEST_DIR=/media/test
export RECREATE_TEST_DEV=true
# Test with default mount options
[tmpfs_default]
[tmpfs_noswap_huge_never]
TMPFS_MOUNT_OPTIONS="-o noswap,huge=never"
[tmpfs_noswap_huge_always]
TMPFS_MOUNT_OPTIONS="-o noswap,huge=always"
>
> Thanks,
> Zorro
>
> > }
> >
> > _supports_filetype()
> >
> > --
> > 2.43.0
> >
> >
> >
