On Tue, Jun 25, 2024 at 10:02:33PM +0800, Chao Yu wrote: > In this patch, we simulate race case in between sqlite atomic write > and direct IO w/ below steps: > 1. create a regular file, and initialize it w/ 0xff data > 2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it > 3. write transaction data > 4. trigger direct read/write IO on it to check whether it fails or not > 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) > This is a regression test to check handling of race condition in > between atomic_write and direct IO. > > Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > Cc: Daeho Jeong <daehojeong@xxxxxxxxxx> > Signed-off-by: Chao Yu <chao@xxxxxxxxxx> > --- > tests/f2fs/004 | 45 +++++++++++++++++++++++++++++++++++++++++++++ > tests/f2fs/004.out | 3 +++ > 2 files changed, 48 insertions(+) > create mode 100755 tests/f2fs/004 > create mode 100644 tests/f2fs/004.out > > diff --git a/tests/f2fs/004 b/tests/f2fs/004 > new file mode 100755 > index 00000000..26862cb5 > --- /dev/null > +++ b/tests/f2fs/004 > @@ -0,0 +1,45 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2024 Oppo. All Rights Reserved. > +# > +# FS QA Test No. f2fs/004 > +# > +# Test that we will simulate race case in between sqlite atomic write > +# and direct IO w/ below steps: > +# 1. create a regular file, and initialize it w/ 0xff data > +# 2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it > +# 3. write transaction data > +# 4. trigger direct read/write IO to check whether it fails or not > +# 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) > +# This is a regression test to check handling of race condition in > +# between atomic_write and direct IO. Same as last patch, please add _fixed_by_kernel_commit. > +# > +. ./common/preamble > +_begin_fstest auto quick > + > +. ./common/filter > + > +_supported_fs f2fs ^^^^^ It's not needed > +_require_scratch > +_require_xfs_io_command "pwrite" ^^^^ It can be removed too I think. > + > +_scratch_mkfs >> $seqres.full > +_scratch_mount >> $seqres.full > + > +dbfile=$SCRATCH_MNT/dbfile > + > +# start atomic_write on dbfile & write data to dbfile > +touch $dbfile > +$F2FS_IO_PROG write 1 0 32 zero atomic_commit $dbfile 3000 >> $seqres.full & There's a backgroup process too. Better to make sure it's done "kill && wait" before the end of the test. > + > +# simulate concurrent direct read/write IO > +$XFS_IO_PROG -d -c "pread 0 128k" $dbfile > +$XFS_IO_PROG -d -c "pwrite 0 128k" $dbfile Do you need _require_odirect (not sure about that:). > + > +# wait for atomic_write commit completion > +sleep 5 > + > +_scratch_unmount ^^^^ It's not necessary. Thanks, Zorro > + > +status=0 > +exit > diff --git a/tests/f2fs/004.out b/tests/f2fs/004.out > new file mode 100644 > index 00000000..3af79541 > --- /dev/null > +++ b/tests/f2fs/004.out > @@ -0,0 +1,3 @@ > +QA output created by 004 > +pread: Operation not supported > +pwrite: Operation not supported > -- > 2.40.1 > >
