On Mon, Jul 1, 2024 at 10:52 PM Daniel Gomez via B4 Relay
<devnull+da.gomez.samsung.com@xxxxxxxxxx> wrote:
>
> From: Daniel Gomez <da.gomez@xxxxxxxxxxx>
>
> MOUNT_OPTIONS for scratch devices do not have specific fs mount options
> values (such as TMPFS_MOUNT_OPTIONS) from the config section. So, allow
> the scratch mount options to inherit section config values by reading
> them from _common_mount_opts().
>
> Move $* to the end so scratch device can be umount/mount. Otherwise, we
> end up with multiple mounts in the same scratch directory.
>
> Signed-off-by: Daniel Gomez <da.gomez@xxxxxxxxxxx>
> ---
> common/rc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 51827119c..627dbaaaa 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -231,8 +231,8 @@ _scratch_mount_options()
> {
> _scratch_options mount
>
> - echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
> - $SCRATCH_DEV $SCRATCH_MNT
> + echo `_common_mount_opts` $SCRATCH_OPTIONS \
> + $SCRATCH_DEV $SCRATCH_MNT $*
Why change the _common_dev_mount_options to _common_mount_opts? They're totally
different two functions. And this change will cause many test cases fail.
Thanks,
Zorro
>
> }
>
> _supports_filetype()
>
> --
> 2.43.0
>
>
>
