Re: [PATCH] xfs/011: support byte-based grant heads are stored in bytes now

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Jun 21, 2024 at 08:29:03AM +0200, Christoph Hellwig wrote:
> On Thu, Jun 20, 2024 at 12:56:06PM -0700, Darrick J. Wong wrote:
> > > +	# The grant heads record reservations in bytes.  For complex reasons
> > > +	# beyond the scope fo this test, these aren't going to be exactly zero
> > 
> >                            of
> > 
> > Why aren't they going to be exactly zero?
> 
> Given that frozen file systems always have a dirty log to force
> recovery after a crash we also have space granted to it.

Might as well say that in the comment, then.

"The grant heads record log reservations in bytes.  Frozen filesystems
always have a dirty log to force recovery, so the grant heads won't be
exactly zero..."

With something like that
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux