On Tue, May 21, 2024 at 01:01:29PM +0100, fdmanana@xxxxxxxxxx wrote:
> From: Filipe Manana <fdmanana@xxxxxxxx>
>
> As of commit 5d6f0e9890ed ("btrfs: stop locking the source extent range
> during reflink"), btrfs now does reflink operations without locking the
> source file's range, allowing concurrent reads in the whole source file.
> So update the test to annotate that commit.
>
> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
> ---
Make sense to me, Thanks!
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>
> tests/generic/733 | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/tests/generic/733 b/tests/generic/733
> index d88d92a4..f6ee7f71 100755
> --- a/tests/generic/733
> +++ b/tests/generic/733
> @@ -7,7 +7,8 @@
> # Race file reads with a very slow reflink operation to see if the reads
> # actually complete while the reflink is ongoing. This is a functionality
> # test for XFS commit 14a537983b22 "xfs: allow read IO and FICLONE to run
> -# concurrently".
> +# concurrently" and for BTRFS commit 5d6f0e9890ed "btrfs: stop locking the
> +# source extent range during reflink".
> #
> . ./common/preamble
> _begin_fstest auto clone punch
> @@ -26,8 +27,16 @@ _require_test_program "punch-alternating"
> _require_test_program "t_reflink_read_race"
> _require_command "$TIMEOUT_PROG" timeout
>
> -[ "$FSTYP" = "xfs" ] && _fixed_by_kernel_commit 14a537983b22 \
> - "xfs: allow read IO and FICLONE to run concurrently"
> +case "$FSTYP" in
> +"btrfs")
> + _fixed_by_kernel_commit 5d6f0e9890ed \
> + "btrfs: stop locking the source extent range during reflink"
> + ;;
> +"xfs")
> + _fixed_by_kernel_commit 14a537983b22 \
> + "xfs: allow read IO and FICLONE to run concurrently"
> + ;;
> +esac
>
> rm -f "$seqres.full"
>
> --
> 2.43.0
>
>
