On Wed, May 08, 2024 at 10:40:07PM -0700, Christoph Hellwig wrote: > On Tue, May 07, 2024 at 09:07:36PM +0200, David Sterba wrote: > > The shared/ directory was supposed to host tests that apply to a subset > > of all supported filesystems but this is not utilized much and creates a > > split from the generic tests. Move the test to generic. > > While we're at it, can we please have a > > _have_mkfs_overwrite detetion instead of hardcoding ext4 and btrfs > with another check for that is supported for btrfs? > > I'm also pretty sure at least ext4 supports overwrite detection as > well.. Yeah, that's the reason I still keep the shared as a "prefix directory" of generic. The hardcode whitelist or blacklist of _supported_fs is a bit rude. If a fs isn't supported by a test case totally, that's fine. But if the condition of _notrun can be smaller and more precise (refer to some _require_xxx helpers) that would be great. Of course we can move shared to generic at first, then improve it later. But I doubt if we can keep that in mind, due to there're hundreds of generic cases :) Thanks, Zorro > >
