Re: [PATCH] generic/095: add to the quick group

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sun, Apr 28, 2024 at 01:49:53AM +0800, Zorro Lang wrote:
> On Sat, Apr 27, 2024 at 09:55:30AM +0200, Christoph Hellwig wrote:
> > generic/095 doesn't take more than 4 seconds on any of my test setups,
> 
> Yeah, it generally takes ~5 seconds. But there's a "LOAD_FACTOR", so

On what kind of storage hardware?  If it's that fast even on spinning
rust then I guess you could double the iodepth*/numjobs computations.

(What happens if numjobs exceeds the 9 defined in the fio config file?)

> before we add it into quick group, I'd like to ask
> do you think if it's worth increasing the default LOAD_FACTOR a bit to
> give it more stress, or move it to quick group directly?

I'd move it to the quick group.

--D

> > but is exercises code that handles buffered write iterations interrupted
> > by concurrent direct I/O that no other test in the quick group does.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > ---
> >  tests/generic/095 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/generic/095 b/tests/generic/095
> > index 80448200b..9d0446e98 100755
> > --- a/tests/generic/095
> > +++ b/tests/generic/095
> > @@ -7,7 +7,7 @@
> >  # Concurrent mixed I/O (buffer I/O, aiodio, mmap, splice) on the same files
> >  #
> >  . ./common/preamble
> > -_begin_fstest auto rw stress
> > +_begin_fstest auto quick rw stress
> >  
> >  # Import common functions.
> >  . ./common/filter
> > -- 
> > 2.39.2
> > 
> > 
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux