Re: [PATCH] fstests: solve no-return-in-nonvoid-function issue

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Apr 26, 2024 at 10:52:59PM -0700, Christoph Hellwig wrote:
> On Wed, Apr 24, 2024 at 07:24:08PM +0800, Yong Sun wrote:
> > --- a/src/fake-dump-rootino.c
> > +++ b/src/fake-dump-rootino.c
> > @@ -221,4 +221,5 @@ int main(int argc, char *argv[]) {
> >  
> >  	munmap(header, GLOBAL_HDR_SZ);
> >  	close(fd);
> > +        return 0;
> 
> This needs to use a tab instead of spaces.  Otherwise looks good:

Yes, I'll help to change that, thanks!

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux