On Thu, Apr 11, 2024 at 04:32:33PM +1000, David Disseldorp wrote:
> As of xfsprogs commit 6e0ed3d1 ("mkfs: stop allowing tiny filesystems")
> attempts to create XFS filesystems sized under 300M fail, unless
> TEST_DIR, TEST_DEV and QA_CHECK_FS environment variables are exported
> (or a --unsupported mkfs parameter is provided).
>
> TEST_DIR and QA_CHECK_FS are already exported, while TEST_DEV may only
> be locally set if provided via e.g. configs/$HOSTNAME.config. Explicitly
> export TEST_DEV to ensure that tests which call _scratch_mkfs_sized()
> with an fssize under 300M run normally.
As for fixing the immediate problem this looks fine:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
But adding the xfs list as allowing to create a smaller than supported
file system just for testing is pretty silly. If we don't want to
support these tiny file systems, we should also not use them for
testing. The best way to port over the existing tests to a larger
size would probably be to round up the size to the minimum supported
one and then fill the space?
