On Tue, Apr 02, 2024 at 02:22:14PM +0800, 蔡晓斌 wrote: > > > > At 2024-04-02 12:51:35, "David Disseldorp" <ddiss@xxxxxxx> wrote: > >Hi, > > > >On Tue, 2 Apr 2024 09:41:49 +0800 (CST), 蔡晓斌 wrote: > >... > >> From 40ff753ffb3dd4ab8789699dc45a83ece64a3626 Mon Sep 17 00:00:00 2001 > >> From: "cai.xiaobin" <cai.xiaobin@xxxxxxxxxxxx> > >> Date: Wed, 20 Mar 2024 11:13:29 +0800 > >> Subject: [PATCH] generic/556: reverse the order of comments to make the file > >> look more like a script file > >> > >> > >> --- > >> tests/generic/556 | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> > >> diff --git a/tests/generic/556 b/tests/generic/556 > >> index 404a3243..ccefbcc4 100755 > >> --- a/tests/generic/556 > >> +++ b/tests/generic/556 > >> @@ -1,5 +1,5 @@ > >> -# SPDX-License-Identifier: GPL-2.0+ > >> #!/bin/bash > >> +# SPDX-License-Identifier: GPL-2.0+ > >> # FS QA Test No. 556 > >> # > >> # Test the basic functionality of filesystems with case-insensitive > > > >Looks fine to me, although I'd suggest a simpler patch description: > > generic/556: move shebang to first line > > > > >Reviewed-by: David Disseldorp <ddiss@xxxxxxx> > > > Wow, your suggestion is good. Do I need to provide another patch with a correction commit? > Thank you for your reply. Looks like there're many special characters in this patch, please send a normal "pure text" patch, with a proper subject and commit log. Thanks, Zorro
