On Thu, Mar 28, 2024 at 08:05:42AM -0700, Darrick J. Wong wrote: > > The crc=0 forcing case seems only to activate if > XFS_MKFS_HAS_NO_META_SUPPORT is non-empty, which happens only if > mkfs.xfs does /not/ support V5 filesystems. Maybe we can drop that > case? The way I read it is is that it is activate if XFS_MKFS_HAS_NO_META_SUPPORT is emtpy, that is if CRC are supported and it then disables them. But only for < 1024 bytes block sizes, which we don't actually support for crc-enabled file systems. Maybe just drop the 512 byte block size testing from this patch entirely? And with that the rather oddly named XFS_MKFS_HAS_NO_META_SUPPORT variable can go away as well. > > xfs/096 requires an obsolete mkfs without input validation, but > > I guess adding the doesn't hurt > > Why do we even keep this test then? Do we care about xfsprogs 4.5? > 4.19^H4 is the oldest LTS kernel... Good point. I'll add a patch to remove it.
