Re: [PATCH 2/3] fstests: btrfs/195: skip raid setups not in the profile configs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 3/19/24 22:25, Josef Bacik wrote:
You can specify a custom BTRFS_PROFILE_CONFIGS to skip certain raid
configurations in the tests, however btrfs/195 doesn't honor this
currently.  Fix this up by getting the profile configs and skipping any
configurations that are not listed in BTRFS_PROFILE_CONFIGS.

Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>

This doesn't use _require_btrfs_fs_feature raid56,
so applied. Included for the PR.

Thanks, Anand

---
  tests/btrfs/195 | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/tests/btrfs/195 b/tests/btrfs/195
index 96cc4134..df8f5ed6 100755
--- a/tests/btrfs/195
+++ b/tests/btrfs/195
@@ -21,6 +21,9 @@ _require_scratch_dev_pool 4
  # Zoned btrfs only supports SINGLE profile
  _require_non_zoned_device "${SCRATCH_DEV}"
+# Load up the available configs
+_btrfs_get_profile_configs
+
  declare -a TEST_VECTORS=(
  # $nr_dev_min:$data:$metadata:$data_convert:$metadata_convert
  "4:single:raid1"
@@ -38,6 +41,11 @@ run_testcase() {
  	src_type=${args[1]}
  	dst_type=${args[2]}
+ if [[ ! "${_btrfs_profile_configs[@]}" =~ "$dst_type" ]]; then
+		echo "=== Skipping test: $1 ===" >> $seqres.full
+		return
+	fi
+
  	_scratch_dev_pool_get $num_disks
echo "=== Running test: $1 ===" >> $seqres.full





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux