On Tue, Mar 19, 2024 at 02:01:00PM -0700, Christoph Hellwig wrote: > On Tue, Mar 19, 2024 at 07:12:10PM +0100, David Sterba wrote: > > This tests if a clone source can be read but in btrfs there's an > > exclusive lock and the test always fails. The functionality might be > > implemented in btrfs in the future but for now disable the test. > > Well, this sounds like btrf sis broken and it should fail? > > > # real QA test starts here > > -_supported_fs generic > > +_supported_fs ^btrfs > > > and just throwing random not supported in generic testes is just a mine > field. You;d better explain very well why something is not supported, > and do that by adding a _require_. If you can't explain the > _require this probably actually is a bug and not just an exclude.. I don't think there's a good way to _require-test for holding i_rwsem in exclusive or shared mode during an FICLONE operation. But that ought to be a comment somewhere at least. --D
