On 3/19/24 09:46, Zorro Lang wrote:
On Mon, Mar 18, 2024 at 11:02:19PM +0100, David Sterba wrote:
On Sat, Mar 16, 2024 at 10:32:33PM +0530, Anand Jain wrote:
Given that ext4 also allows mounting of a cloned filesystem, the btrfs
test case btrfs/312, which assesses the functionality of cloned filesystem
support, can be refactored to be under the shared group.
Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
---
v2:
Move to shared testcase instead of generic.
What's the purpose of shared/ ? We have tests that make sense for a
subset of supported filesystems in generic/, with proper _required and
other the checks it works fine.
I see that v1 did the move to generic/ but then the 'shared' got
suggested, which is IMHO the wrong direction. I remember some distant
past discussions about shared/ and what to put there. Right now there
are 3 remaining tests which I think is a good opportunity to make it 0.
I didn't suggest to make it a shared case directly,
I asked if there's a
_require_xxxx helper to make this case notrun on "not proper" fs,
not just use "btrfs ext4" to be whitelist :
https://lore.kernel.org/fstests/20240312044629.hpaqdkl24nxaa3dv@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
In my personal opinion, the "shared" directory is a place to store the cases
which are nearly to be generic, but not ready. It's a place to remind us
there're still some cases use something likes "supported btrfs ext4" as the
hard condition of _notrun, rather than a flexible _require_xxx helper. These
cases in shared better to be moved to generic, if we can improve it in one day.
It more likes a "TODO" list of generic. If we just write it in generic/
directory, I'm afraid we'll leave it in hundreds of generic cases then forget it.
What do you think?
Based on my understanding, here is the original approach:
fstests/generic: Includes tests applicable to all file systems.
tests/shared: Consists of tests supported by two or more file systems.
However, currently, the test cases are not properly organized.
Moreover, fstests/generic is nearing 999 test cases.
Segregating tests between shared and generic can optimize group size.
But, I am fine if we give away 'shared' to `generic` instead.
Thanks, Anand
