Re: [PATCH v2] fstests: add missing commit IDs to some tests

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Mar 13, 2024 at 03:41:36PM +0000, fdmanana@xxxxxxxxxx wrote:
> From: Filipe Manana <fdmanana@xxxxxxxx>
> 
> Some tests are still using a 'xxx...' commit ID but the respective patches
> were already merged to Linus' tree or btrfs-progs, so update them with the
> correct commit IDs and in two cases update the subject as well, because it
> was modified after the test case was added and before being sent to Linus
> (btrfs/317 and generic/707).
> 
> Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
> ---
> 
> V2: Also add a missing btrfs-progs commit ID to btrfs/249 and ext4 commit ID
>     to generic/707.

Thanks!

Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

> 
>  tests/btrfs/249   | 2 +-
>  tests/btrfs/303   | 2 +-
>  tests/btrfs/309   | 2 +-
>  tests/btrfs/316   | 2 +-
>  tests/btrfs/317   | 4 ++--
>  tests/generic/707 | 4 ++--
>  6 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/btrfs/249 b/tests/btrfs/249
> index 06cc444b..0355434b 100755
> --- a/tests/btrfs/249
> +++ b/tests/btrfs/249
> @@ -28,7 +28,7 @@ _require_command "$WIPEFS_PROG" wipefs
>  _require_btrfs_forget_or_module_loadable
>  _wants_kernel_commit a26d60dedf9a \
>  	"btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device"
> -_fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \
> +_fixed_by_git_commit btrfs-progs 32c2e57c65b9 \
>  	"btrfs-progs: read fsid from the sysfs in device_is_seed"
>  
>  _scratch_dev_pool_get 2
> diff --git a/tests/btrfs/303 b/tests/btrfs/303
> index 26bcfe41..ed3abcc1 100755
> --- a/tests/btrfs/303
> +++ b/tests/btrfs/303
> @@ -25,7 +25,7 @@ _require_test
>  _require_scratch
>  _require_xfs_io_command "fiemap"
>  
> -_fixed_by_kernel_commit XXXXXXXXXXXX \
> +_fixed_by_kernel_commit 5897710b28ca \
>  	"btrfs: send: don't issue unnecessary zero writes for trailing hole"
>  
>  send_files_dir=$TEST_DIR/btrfs-test-$seq
> diff --git a/tests/btrfs/309 b/tests/btrfs/309
> index 5cbcd223..d1eb953f 100755
> --- a/tests/btrfs/309
> +++ b/tests/btrfs/309
> @@ -12,7 +12,7 @@ _begin_fstest auto quick snapshot subvol
>  _supported_fs btrfs
>  _require_scratch
>  _require_test_program t_snapshot_deleted_subvolume
> -_fixed_by_kernel_commit XXXXXXXXXXXX \
> +_fixed_by_kernel_commit 7081929ab257 \
>  	"btrfs: don't abort filesystem when attempting to snapshot deleted subvolume"
>  
>  _scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed"
> diff --git a/tests/btrfs/316 b/tests/btrfs/316
> index 07a94334..f78a0235 100755
> --- a/tests/btrfs/316
> +++ b/tests/btrfs/316
> @@ -17,7 +17,7 @@ _begin_fstest auto quick qgroup
>  _supported_fs btrfs
>  _require_scratch
>  
> -_fixed_by_kernel_commit xxxxxxxxxxxx \
> +_fixed_by_kernel_commit d139ded8b9cd \
>  	"btrfs: qgroup: always free reserved space for extent records"
>  
>  _scratch_mkfs >> $seqres.full
> diff --git a/tests/btrfs/317 b/tests/btrfs/317
> index 59686b72..b17ba584 100755
> --- a/tests/btrfs/317
> +++ b/tests/btrfs/317
> @@ -10,8 +10,8 @@
>  . ./common/preamble
>  _begin_fstest auto volume raid convert
>  
> -_fixed_by_kernel_commit XXXXXXXXXX \
> -	"btrfs: zoned: don't skip block group profile checks on conv zones"
> +_fixed_by_kernel_commit 5906333cc4af \
> +	"btrfs: zoned: don't skip block group profile checks on conventional zones"
>  
>  . common/filter.btrfs
>  
> diff --git a/tests/generic/707 b/tests/generic/707
> index ad1592a1..da9dc5b6 100755
> --- a/tests/generic/707
> +++ b/tests/generic/707
> @@ -16,8 +16,8 @@ _require_scratch
>  
>  _fixed_by_kernel_commit f950fd052913 \
>  	"udf: Protect rename against modification of moved directory"
> -_fixed_by_kernel_commit XXXXXXXXXXXX \
> -	"ext4: fix possible corruption when moving a directory"
> +_fixed_by_kernel_commit 0813299c586b \
> +	"ext4: Fix possible corruption when moving a directory"
>  
>  _scratch_mkfs >>$seqres.full 2>&1
>  _scratch_mount
> -- 
> 2.43.0
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux