On Wed, Mar 13, 2024 at 01:39:28PM +0000, fdmanana@xxxxxxxxxx wrote: > From: Filipe Manana <fdmanana@xxxxxxxx> > > Some tests are still using a 'xxx...' commit ID but the respective patches > were already merged to Linus' tree, so update them with the correct commit > IDs and in one case update the subject as well, because it was modified > after the test case was added and before being sent to Linus (btrfs/317). > > Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> > --- > tests/btrfs/303 | 2 +- > tests/btrfs/309 | 2 +- > tests/btrfs/316 | 2 +- > tests/btrfs/317 | 4 ++-- Thanks for this updating. As you're doing this job, would you like to help to update below line of *btrfs/249* by the way: _fixed_by_git_commit btrfs-progs xxxxxxxxxxxx \ "btrfs-progs: read fsid from the sysfs in device_is_seed" And ... if would like to go a step further, you can change one more line in generic/707 to: _fixed_by_kernel_commit 0813299c586b \ "ext4: Fix possible corruption when moving a directory" Then I think you can change the subject of this patch to: "fstests: fix missing commit IDs of _fixed_by_*_commit calls" due to all current missing IDs in fstests will be fixed, don't need one more other patch :) Of course, with this change I'm glad to: Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> Thanks, Zorro > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/btrfs/303 b/tests/btrfs/303 > index 26bcfe41..ed3abcc1 100755 > --- a/tests/btrfs/303 > +++ b/tests/btrfs/303 > @@ -25,7 +25,7 @@ _require_test > _require_scratch > _require_xfs_io_command "fiemap" > > -_fixed_by_kernel_commit XXXXXXXXXXXX \ > +_fixed_by_kernel_commit 5897710b28ca \ > "btrfs: send: don't issue unnecessary zero writes for trailing hole" > > send_files_dir=$TEST_DIR/btrfs-test-$seq > diff --git a/tests/btrfs/309 b/tests/btrfs/309 > index 5cbcd223..d1eb953f 100755 > --- a/tests/btrfs/309 > +++ b/tests/btrfs/309 > @@ -12,7 +12,7 @@ _begin_fstest auto quick snapshot subvol > _supported_fs btrfs > _require_scratch > _require_test_program t_snapshot_deleted_subvolume > -_fixed_by_kernel_commit XXXXXXXXXXXX \ > +_fixed_by_kernel_commit 7081929ab257 \ > "btrfs: don't abort filesystem when attempting to snapshot deleted subvolume" > > _scratch_mkfs >> $seqres.full 2>&1 || _fail "mkfs failed" > diff --git a/tests/btrfs/316 b/tests/btrfs/316 > index 07a94334..f78a0235 100755 > --- a/tests/btrfs/316 > +++ b/tests/btrfs/316 > @@ -17,7 +17,7 @@ _begin_fstest auto quick qgroup > _supported_fs btrfs > _require_scratch > > -_fixed_by_kernel_commit xxxxxxxxxxxx \ > +_fixed_by_kernel_commit d139ded8b9cd \ > "btrfs: qgroup: always free reserved space for extent records" > > _scratch_mkfs >> $seqres.full > diff --git a/tests/btrfs/317 b/tests/btrfs/317 > index 59686b72..b17ba584 100755 > --- a/tests/btrfs/317 > +++ b/tests/btrfs/317 > @@ -10,8 +10,8 @@ > . ./common/preamble > _begin_fstest auto volume raid convert > > -_fixed_by_kernel_commit XXXXXXXXXX \ > - "btrfs: zoned: don't skip block group profile checks on conv zones" > +_fixed_by_kernel_commit 5906333cc4af \ > + "btrfs: zoned: don't skip block group profile checks on conventional zones" > > . common/filter.btrfs > > -- > 2.43.0 > >
