On Fri, Mar 1, 2024 at 1:49 PM Zorro Lang <zlang@xxxxxxxxxx> wrote:
>
> On Thu, Feb 15, 2024 at 10:02:36PM +0800, Su Yue wrote:
> > From: Su Yue <glass.su@xxxxxxxx>
> >
> > Because block group tree requires require no-holes feature,
> > _log_writes_mkfs "-O ^no-holes" fails when "-O block-group-tree" is
> > given in MKFS_OPTION.
> > Without explicit _log_writes_cleanup, the two tests fail with
> > logwrites-test device left. And all next tests will fail due to
> > SCRATCH DEVICE EBUSY.
> >
> > Fix it by overriding _cleanup to call _log_writes_cleanup.
> >
> > Signed-off-by: Su Yue <glass.su@xxxxxxxx>
> > ---
> > tests/btrfs/172 | 6 ++++++
> > tests/btrfs/206 | 6 ++++++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/tests/btrfs/172 b/tests/btrfs/172
> > index f5acc6982cd7..fceff56c9d37 100755
> > --- a/tests/btrfs/172
> > +++ b/tests/btrfs/172
> > @@ -13,6 +13,12 @@
> > . ./common/preamble
> > _begin_fstest auto quick log replay recoveryloop
> >
> > +# Override the default cleanup function.
> > +_cleanup()
> > +{
> > + _log_writes_cleanup &> /dev/null
>
> This _cleanup will override the default one, so better to copy the
> default cleanup in this function,
>
> cd /
> rm -r -f $tmp.*
Zorro,
You had already replied to v2 of this patch with exactly the same comments:
https://lore.kernel.org/fstests/20240225162212.qcidpyb2bhdburl6@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
It's trivial to do those changes.
Do you expect Su to send yet another version just for that, or could
you amend the patch?
Can you please be more clear in future replies about that, i.e. if you
expect the author to send a new version or if you'll amend the patch
for trivial changes?
Speaking for myself, I very often get confused with your replies, and
I feel that some patches often get stalled for that reason.
Usually with Eryu or Dave that didn't happen, the course of action was clear.
Thanks.
>
> You can refer to btrfs/196 or generic/482 etc.
>
> > +}
> > +
> > # Import common functions.
> > . ./common/filter
> > . ./common/dmlogwrites
> > diff --git a/tests/btrfs/206 b/tests/btrfs/206
> > index f6571649076f..e05adf75b67e 100755
> > --- a/tests/btrfs/206
> > +++ b/tests/btrfs/206
> > @@ -14,6 +14,12 @@
> > . ./common/preamble
> > _begin_fstest auto quick log replay recoveryloop punch prealloc
> >
> > +# Override the default cleanup function.
> > +_cleanup()
> > +{
> > + _log_writes_cleanup &> /dev/null
>
>
> Same as above.
>
> Thanks,
> Zorro
>
> > +}
> > +
> > # Import common functions.
> > . ./common/filter
> > . ./common/dmlogwrites
> > --
> > 2.43.0
> >
> >
>
>
