Re: [PATCH] tests/*/Makefile: make sure group.list DIRT exists before install

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sun, Feb 25, 2024 at 5:35 PM Zorro Lang <zlang@xxxxxxxxxx> wrote:
>
> On Thu, Feb 08, 2024 at 11:52:41PM +0100, Martin Jansa wrote:
> > * sometimes make install was failing with:
> >   cp: cannot stat 'group.list': No such file or directory
> >   and bunch of non-fatal messages:
> >   mv: failed to preserve ownership for 'group.list': Invalid argument
>
> I'm wondering ... isn't that expected?
>
> Why not let "make install" fail directly, if there's not a completed "make" ?
> Isn't that more familiar?

It might if it fails reliably, but in OpenEmbedded builds where I was
seeing this in some CI builds it failed in about 1% of the builds, which is
enough to make the failure annoying and if this is meant to be expected
behavior than not failing reliably, for context see:
https://git.openembedded.org/meta-openembedded/commit/?id=e8a1c9823b7e55dd2ca7f19a3fd3a05ae676bfe2

so here it calls make in do_compile task (defined in autotools-brokensep),
then make install in do_install task and do_install was failing
_sometimes_, and I haven't seen single failure since this change was
applied.

I'm not very familiar with xfstests, I wasn't even building it
intentionally (it's just part of one CI job which builds everything
available), so I might be missing something.

Regards,





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux