On Wed, Feb 21, 2024 at 07:37:41AM +0100, Christoph Hellwig wrote:
> Since kernel commit a951104333bd ("dm error: Add support for zoned block
> devices") dm-error fully supports zoned devices. Make use of that to
> also run error injection tests for zoned device.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> common/rc | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 524ffa02a..f207d8ab2 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2193,12 +2193,10 @@ _require_dm_target()
> _notrun "This test requires dm $target support"
> fi
>
> - # dm-error cannot handle the zone information
> - #
> # dm-snapshot and dm-thin-pool cannot ensure sequential writes on
> # the backing device
> case $target in
> - error|snapshot|thin-pool)
> + snapshot|thin-pool)
This patch makes sense to me, but I think this patch might cause
failures on old kernel which doesn't has kernel commit a951104333bd, right?
Is there a simple way to check if dm-error supports zoned block device? If
there's not, I think we have to let it fails on old kernel, to make it run
on newer kernel.
Thanks,
Zorro
> _require_non_zoned_device ${SCRATCH_DEV}
> ;;
> esac
> --
> 2.39.2
>
