Re: [PATCH v2 08/10] btrfs: verify tempfsid clones using mkfs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 2/20/24 22:25, Filipe Manana wrote:
On Mon, Feb 19, 2024 at 7:50 PM Anand Jain <anand.jain@xxxxxxxxxx> wrote:

Create appearing to be a clone using the mkfs.btrfs option and test if
the tempfsid is active.

Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
---
v2:
  Remove unnecessary function.
  Add clone group
  use $UMOUNT_PROG
  Let _cp_reflink fail on the stdout.

  tests/btrfs/313     | 55 +++++++++++++++++++++++++++++++++++++++++++++
  tests/btrfs/313.out | 16 +++++++++++++
  2 files changed, 71 insertions(+)
  create mode 100755 tests/btrfs/313
  create mode 100644 tests/btrfs/313.out

diff --git a/tests/btrfs/313 b/tests/btrfs/313
new file mode 100755
index 000000000000..c495a770c212
--- /dev/null
+++ b/tests/btrfs/313
@@ -0,0 +1,55 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2024 Oracle.  All Rights Reserved.
+#
+# FS QA Test 313
+#
+# Functional test for the tempfsid, clone devices created using the mkfs option.
+#
+. ./common/preamble
+_begin_fstest auto quick clone tempfsid
+
+_cleanup()
+{
+       cd /
+       $UMOUNT_PROG $mnt1 > /dev/null 2>&1
+       rm -r -f $tmp.*
+       rm -r -f $mnt1
+}
+
+. ./common/filter.btrfs
+. ./common/reflink
+
+_supported_fs btrfs
+_require_cp_reflink
+_require_btrfs_sysfs_fsid
+_require_scratch_dev_pool 2
+_require_btrfs_fs_feature temp_fsid
+_require_btrfs_command inspect-internal dump-super
+_require_btrfs_mkfs_uuid_option

So same as before, these last 2 _require_* are because of the
check_fsid() function,

Yes, they have already been checked in mkfs_clone(),
so they have been removed here.

Thanks.

defined at common/btrfs, so they should be in the function and not
spread over every test case that calls it.

Thanks.

+
+_scratch_dev_pool_get 2
+
+mnt1=$TEST_DIR/$seq/mnt1
+mkdir -p $mnt1
+
+echo ---- clone_uuids_verify_tempfsid ----
+mkfs_clone ${SCRATCH_DEV_NAME[0]} ${SCRATCH_DEV_NAME[1]}
+
+echo Mounting original device
+_mount ${SCRATCH_DEV_NAME[0]} $SCRATCH_MNT
+check_fsid ${SCRATCH_DEV_NAME[0]}
+
+echo Mounting cloned device
+_mount ${SCRATCH_DEV_NAME[1]} $mnt1
+check_fsid ${SCRATCH_DEV_NAME[1]}
+
+$XFS_IO_PROG -fc 'pwrite -S 0x61 0 9000' $SCRATCH_MNT/foo | _filter_xfs_io
+echo cp reflink must fail
+_cp_reflink $SCRATCH_MNT/foo $mnt1/bar 2>&1 | _filter_testdir_and_scratch
+
+_scratch_dev_pool_put
+
+# success, all done
+status=0
+exit
diff --git a/tests/btrfs/313.out b/tests/btrfs/313.out
new file mode 100644
index 000000000000..7a089d2c29c5
--- /dev/null
+++ b/tests/btrfs/313.out
@@ -0,0 +1,16 @@
+QA output created by 313
+---- clone_uuids_verify_tempfsid ----
+Mounting original device
+On disk fsid:          FSID
+Metadata uuid:         FSID
+Temp fsid:             FSID
+Tempfsid status:       0
+Mounting cloned device
+On disk fsid:          FSID
+Metadata uuid:         FSID
+Temp fsid:             TEMPFSID
+Tempfsid status:       1
+wrote 9000/9000 bytes at offset 0
+XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+cp reflink must fail
+cp: failed to clone 'TEST_DIR/313/mnt1/bar' from 'SCRATCH_MNT/foo': Invalid cross-device link
--
2.39.3






[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux