+_begin_fstest auto quick tempfsid
This exercises reflinks, so it should have the 'clone' group as well.
Ok. I've added to the clone group now.
+
+_cleanup()
+{
+ cd /
+ umount $mnt1 > /dev/null 2>&1
Same as mentioned before, use $UMOUNT_PROG
Thx. Fixed it.
+ rm -r -f $tmp.*
+ rm -r -f $mnt1
+}
+
+. ./common/filter.btrfs
+. ./common/reflink
+
+_supported_fs btrfs
+_require_btrfs_sysfs_fsid
+_require_btrfs_fs_feature temp_fsid
+_require_btrfs_command inspect-internal dump-super
Instead of requiring here the inspect-internal command, it should be
inside check_fsid()
That's the pattern we usually do, common functions have the _require_*
calls, avoiding the caller test to have to know each dependency and
copy-paste it.
Sure, I'll moved the prerequisite check to the function check_fsid().
Thx Anand
Other than that, it looks fine.
Thanks.
