On Sun, Feb 11, 2024 at 11:28:26AM +0000, fdmanana@xxxxxxxxxx wrote: > From: Filipe Manana <fdmanana@xxxxxxxx> > > The test is using a 32 characters buffer to print the full path for each > file name, which in some setups it's not enough because $TEST_DIR can > point to a path name longer than that, or even smaller but then the buffer > is still not large enough after appending a file name. When that's the > case it results in a core dump like this: > > generic/736 QA output created by 736 > *** buffer overflow detected ***: terminated > /opt/xfstests/tests/generic/736: line 32: 9217 Aborted (core dumped) $here/src/readdir-while-renames $target_dir > Silence is golden > - output mismatch (see /opt/xfstests/results//generic/736.out.bad) > --- tests/generic/736.out 2024-01-14 12:01:35.000000000 -0500 > +++ /opt/xfstests/results//generic/736.out.bad 2024-01-23 18:58:37.990000000 -0500 > @@ -1,2 +1,4 @@ > QA output created by 736 > +*** buffer overflow detected ***: terminated > +/opt/xfstests/tests/generic/736: line 32: 9217 Aborted (core dumped) $here/src/readdir-while-renames $target_dir > Silence is golden > ... > (Run diff -u /opt/xfstests/tests/generic/736.out /opt/xfstests/results//generic/736.out.bad to see the entire diff) > Ran: generic/736 > Failures: generic/736 > Failed 1 of 1 tests > > We don't actually need to print the full path into the buffer, because we > have previously set the current directory (chdir) to the path pointed by > "dir_path". So fix this by printing only the relative path name which > uses at most 5 characters (NUM_FILES is 5000 plus the nul terminator). > > Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> Reviewed-by: David Sterba <dsterba@xxxxxxxx>
