Re: [PATCH] generic/597,598: Require groups

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Sun, Jan 14, 2024 at 10:56:11AM +0100, Richard Weinberger wrote:
> Moving to a new test bed is always fun.
> Forgot to add group fsgqa2 and tests 597, 598 failed.
> 
> generic/597       - output mismatch (see /root/xfstests-dev/results//generic/597.out.bad)
>     --- tests/generic/597.out   2024-01-14 08:55:20.176084268 +0000
>     +++ /root/xfstests-dev/results//generic/597.out.bad 2024-01-14 09:41:15.548729962 +0000
>     @@ -2,13 +2,17 @@
>      == Test symlink follow protection when
>      == process != link owner and dir owner != link owner
>      fs.protected_symlinks = 0
>     +chown: invalid group: 'fsgqa2:fsgqa2'
>      successfully followed symlink
>      fs.protected_symlinks = 1
>     +chown: invalid group: 'fsgqa2:fsgqa2'
> 
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---

Looks good to me,
Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

>  tests/generic/597 | 2 ++
>  tests/generic/598 | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/tests/generic/597 b/tests/generic/597
> index ff985ca61915..a3035489aea3 100755
> --- a/tests/generic/597
> +++ b/tests/generic/597
> @@ -32,8 +32,10 @@ _require_test
>  _require_sysctl_variable fs.protected_symlinks
>  _require_sysctl_variable fs.protected_hardlinks
>  _require_user fsgqa2
> +_require_group fsgqa2
>  # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account
>  _require_user fsgqa
> +_require_group fsgqa
>  _require_symlinks
>  
>  OWNER=fsgqa2
> diff --git a/tests/generic/598 b/tests/generic/598
> index 769c1b1a1ad9..31b7fde48868 100755
> --- a/tests/generic/598
> +++ b/tests/generic/598
> @@ -32,8 +32,10 @@ _require_test
>  _require_sysctl_variable fs.protected_regular
>  _require_sysctl_variable fs.protected_fifos
>  _require_user fsgqa2
> +_require_group fsgqa2
>  # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account
>  _require_user fsgqa
> +_require_group fsgqa
>  _require_chmod
>  
>  USER1=fsgqa2
> -- 
> 2.26.2
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux